[GH-34] Ratio Color Additions #46

New issue

Open

opened 2025-11-21 16:55:18 -05:00 by cj · 1 comment

cj commented

2025-11-21 16:55:18 -05:00

Owner

Mirrored from GitHub issue #34

Original author: @xstefanx

Created at: 2023-09-26T15:11:46Z

Labels: wontfix

Description

This isn't a change that is needed in your releases, but I was wanting to customize some ratio colors for myself similar to request #24 and I seem to be missing something and was hoping you might be able to help guide me.

I was thinking there were only two items that would need to be updated, core.css and dynamicTable.js. Here are the changes I had made to them.

core.css:

.highlight-blue {
	color: var(--highlight-color--blue) !important;
}

.highlight-purple {
	color: var(--highlight-color--purple) !important;
}

dynamicTable.js:

		} else if (string > "0.80" && string <= "4.99") {
                    td.classList.add('highlight-brightgreen');
                } else if (string > "4.99" && string <= "9.99") {
                    td.classList.add('highlight-blue');
                } else if (string > "9.99") {
                    td.classList.add('highlight-purple');

These changes didn't seem to have the desired effect however, anything 4.99 or higher ratio is still showing as bright green, even after a cache clear and browser restart. Is there more to changing this that I overlooked?

*Mirrored from GitHub issue [#34](https://github.com/Carve/qbittorrent-webui-cjratliff.com/issues/34)* **Original author: @xstefanx** **Created at: 2023-09-26T15:11:46Z** **Labels:** `wontfix` ## Description This isn't a change that is needed in your releases, but I was wanting to customize some ratio colors for myself similar to request #24 and I seem to be missing something and was hoping you might be able to help guide me. I was thinking there were only two items that would need to be updated, core.css and dynamicTable.js. Here are the changes I had made to them. core.css: ``` .highlight-blue { color: var(--highlight-color--blue) !important; } .highlight-purple { color: var(--highlight-color--purple) !important; } ``` dynamicTable.js: ``` } else if (string > "0.80" && string <= "4.99") { td.classList.add('highlight-brightgreen'); } else if (string > "4.99" && string <= "9.99") { td.classList.add('highlight-blue'); } else if (string > "9.99") { td.classList.add('highlight-purple'); ``` These changes didn't seem to have the desired effect however, anything 4.99 or higher ratio is still showing as bright green, even after a cache clear and browser restart. Is there more to changing this that I overlooked?

cj commented

2025-11-21 16:55:19 -05:00

Author

Owner

Mirrored from GitHub comment by @Carve

Created at: 2023-10-04T00:32:52Z

This isn't a change that is needed in your releases, but I was wanting to customize some ratio colors for myself similar to request #24 and I seem to be missing something and was hoping you might be able to help guide me.

I was thinking there were only two items that would need to be updated, core.css and dynamicTable.js. Here are the changes I had made to them.

core.css:
.highlight-blue {
	color: var(--highlight-color--blue) !important;
}

.highlight-purple {
	color: var(--highlight-color--purple) !important;
}
dynamicTable.js:
		} else if (string > "0.80" && string <= "4.99") {
                    td.classList.add('highlight-brightgreen');
                } else if (string > "4.99" && string <= "9.99") {
                    td.classList.add('highlight-blue');
                } else if (string > "9.99") {
                    td.classList.add('highlight-purple');
These changes didn't seem to have the desired effect however, anything 4.99 or higher ratio is still showing as bright green, even after a cache clear and browser restart. Is there more to changing this that I overlooked?

That should be all it requires, have you made sure to clear your cache / try incognito?

*Mirrored from GitHub comment by @Carve* **Created at: 2023-10-04T00:32:52Z** > This isn't a change that is needed in your releases, but I was wanting to customize some ratio colors for myself similar to request #24 and I seem to be missing something and was hoping you might be able to help guide me. > > I was thinking there were only two items that would need to be updated, core.css and dynamicTable.js. Here are the changes I had made to them. > > core.css: > > ``` > .highlight-blue { > color: var(--highlight-color--blue) !important; > } > > .highlight-purple { > color: var(--highlight-color--purple) !important; > } > ``` > > dynamicTable.js: > > ``` > } else if (string > "0.80" && string <= "4.99") { > td.classList.add('highlight-brightgreen'); > } else if (string > "4.99" && string <= "9.99") { > td.classList.add('highlight-blue'); > } else if (string > "9.99") { > td.classList.add('highlight-purple'); > ``` > > These changes didn't seem to have the desired effect however, anything 4.99 or higher ratio is still showing as bright green, even after a cache clear and browser restart. Is there more to changing this that I overlooked? That should be all it requires, have you made sure to clear your cache / try incognito?